Theme JSON: Fix handling of default presets at block level #10460
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
aaronrobertshaw
force-pushed
the
fix/default-preset-handling-at-block-level
branch
from
7c05430 to
3b3d7de
Compare
aaronrobertshaw
requested review from
andrewserong,
ramonjd,
talldan and
tellthemachines
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
2 participants
Trac ticket: https://core.trac.wordpress.org/ticket/64195
This PR brings the changes from the following Gutenberg PRs to core:
WordPress/gutenberg#72916
Description
Prevents an issue where block level presets do not work correctly when:
The result is missing presets in the settings and editor UI.
Testing
For each theme.json example config below:
Duotone
In the image block, only the "Dark grayscale" duotone preset should be available
{ "version": 3, "appearanceTools": true, "settings": { "blocks":{ "core/image": { "color": { "defaultDuotone": false, "duotone": [ { "name": "Dark grayscale", "colors": [ "#000000", "#7f7f7f" ], "slug": "dark-grayscale" } ] } } } } }Shadow
In the image block, only the "Natural" shadow preset should be available
{ "version": 3, "settings": { "appearanceTools": true, "blocks":{ "core/image": { "shadow": { "defaultPresets": false, "presets": [ { "name": "Natural", "slug": "natural", "shadow": "6px 6px 9px rgba(0, 0, 0, 0.2)" } ] } } } } }Font Size
In the Paragraph block, only the "Small" duotone preset should be available
{ "version": 3, "settings": { "appearanceTools": true, "blocks":{ "core/paragraph": { "typography": { "defaultFontSizes": false, "fontSizes": [ { "name": "Small", "slug": "small", "size": "13px" } ] } } } } }Screenshots or screencast
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.